Have been dating for 4 years should he be ready for marriage?

If he isn't ready, it really doesn't matter whether he should be or not. He shouldn't marry anyone until he feels he is ready to do so. How long you want to wait around for something that may never happen (he may never actually want to marry you) is for you to decide.